Skip to content

fix: removeLastCharacter가 이모지를 반쪽만 지우는 문제 수정 - #412

Open
Choi-Jung-Hyeon wants to merge 1 commit into
toss:mainfrom
Choi-Jung-Hyeon:fix/remove-last-character-surrogate
Open

Choi-Jung-Hyeon wants to merge 1 commit into
toss:mainfrom
Choi-Jung-Hyeon:fix/remove-last-character-surrogate

Conversation

@Choi-Jung-Hyeon

Copy link
Copy Markdown

Overview

removeLastCharacter가 이모지처럼 코드 유닛 두 개로 된 문자를 반쪽만 지워서 깨진 문자열을 반환해요. (#410에서 질문드렸던 내용이에요.)

removeLastCharacter('안녕😀'); // 수정 전: '안녕\ud83d', 수정 후: '안녕'

마지막 문자를 words[words.length - 1] 대신 코드 포인트 단위로 가져오도록 바꿨어요.

👨‍👩‍👧처럼 여러 코드 포인트를 이어 붙인 이모지는 이 PR 범위에 넣지 않았어요. 여전히 마지막 코드 포인트 하나만 지워져요.

PR Checklist

  • I read and included theses actions below
  1. I have read the Contributing Guide
  2. I have written documents and tests, if needed.

🤖 Generated with Claude Code

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@vercel

vercel Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
es-hangul Error Error Nov 12, 2026 5:33am UTC

Request Review

@changeset-bot

changeset-bot Bot commented Nov 12, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: b8595df

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
es-hangul Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

This branch had an error being deployed

1 failed deployment
Preview — b8595df4 Deployed Nov 12, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant